Become SubDAO #1779
Merged
Become SubDAO #1779
+521
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikitatrifan
commented
May 29, 2024
packages/stateful/actions/core/dao_governance/BecomeSubDao/index.tsx
Outdated
Show resolved
Hide resolved
NoahSaso
requested changes
Jun 3, 2024
There was a problem hiding this comment.
love how simple this is, nice :)
just a few small fixes.
also something we need to figure out: after the parent accepts the admin nomination, it also needs to execute on behalf of the SubDAO (with its newly obtained admin privileges) the message to update the wasm contract-level admin to the parent. this is required so that the SubDAO can't just upgrade its own contract later and take power back from the parent, and also so the parent obtains the permission to upgrade it instead. to do this, in the parent's accept subDAO action, we can programmatically add the update admin action
packages/stateful/actions/core/dao_governance/BecomeSubDao/index.tsx
Outdated
Show resolved
Hide resolved
packages/stateful/actions/core/dao_governance/BecomeSubDao/index.tsx
Outdated
Show resolved
Hide resolved
packages/stateful/actions/core/dao_governance/AcceptSubDao/index.tsx
Outdated
Show resolved
Hide resolved
packages/stateful/actions/core/dao_governance/AcceptSubDao/index.tsx
Outdated
Show resolved
Hide resolved
packages/stateful/actions/core/dao_governance/AcceptSubDao/README.md
Outdated
Show resolved
Hide resolved
NoahSaso
requested changes
Jun 6, 2024
packages/stateful/actions/core/dao_governance/AcceptSubDao/index.tsx
Outdated
Show resolved
Hide resolved
NoahSaso
force-pushed
the
trifan/become-sub-dao-action
branch
from
c521923 to
7f7fa9f
Compare
NoahSaso
force-pushed
the
trifan/become-sub-dao-action
branch
from
7f7fa9f to
431b0e7
Compare
… and registering subDAO), and fixed action detection
NoahSaso
force-pushed
the
trifan/become-sub-dao-action
branch
from
431b0e7 to
66908dd
Compare
NoahSaso
approved these changes
Jul 17, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing the two new actions, letting DAOs become SubDAOs.